Am 10.02.19 um 00:29 schrieb Jeff King: > On Sat, Feb 09, 2019 at 09:39:43AM +0100, Johannes Sixt wrote: >> dd of="$objdir/info/commit-graph" bs=1 seek="$zero_pos" count=0 && >> - dd if=/dev/zero of="$objdir/info/commit-graph" bs=1 seek="$zero_pos" count=$(($orig_size - $zero_pos)) && >> + printf "%0*d" $(($orig_size - $zero_pos)) 0 | tr 0 '\0' | >> + dd of="$objdir/info/commit-graph" bs=1 seek="$zero_pos" && > > Using stdin instead of the tmpfile is nice, and shouldn't have any > problems. I do think your printf suggestion looks nice, but I wondered > if it might run into portability issues (not because of anything in > particular, but I often find that the more clever a shell solution, the > more likely we run into obscure problems). > > But if it works everywhere, that's fine by me. Unfortunately, it does not work as intended: the printf solution cannot print nothing, but that should be the case in all but one of the tests. -- Hannes
