On February 8, 2019 11:51, Jeff King wrote: > On Fri, Feb 08, 2019 at 06:08:33AM -0500, Randall S. Becker wrote: > > > t5318 is rather problematic and I have no good way to fix this. There > > is no /dev/zero on the platform, and the corrupt_graph_and_verify > > hard-codes if=/dev/zero, which is a linux-specific pseudo device. > > Please provide a more platform independent way of testing this > > feature. Pretty much all subtests from 46 onward fail as a result. > > We did discuss this at the time of the patch, but it seems we already use > /dev/zero in a bunch of places: > > https://public-inbox.org/git/xmqqbm57rkg5.fsf@xxxxxxxxxxxxxxxxxxxxxxxxx/ > > Were you just skipping the other tests before? I did not catch the implications of the review at the time - my bad. We were not intentionally skipping the tests. It looks like some are automatically skipped. t4153 automatically skips (missing TTY), and t5562 fails also but for a different reason (hang - we don't have apache2 to serve up http content). Would you object to something like this: if [ ! -e /dev/zero ]; then # use shred or some other mechanism (still trying to figure out a solution) else # existing dd fi
