On Tue, Feb 05, 2019 at 04:21:22PM -0800, Jonathan Tan wrote: > In post_rpc(), remote-curl calls credential_fill() if HTTP_REAUTH is > returned, but this is not true in proxy_request(). Do this in > proxy_request() too. Can we do this as a general rule? If we look at the code in post_rpc(), there are two cases: when large_request is set and when it is not. When it's not, we have the whole request in a buffer, and we can happily resend it. But when it's not, we cannot restart it, because we'll have thrown away some of the data. So we send an initial probe_rpc() as a sanity check. If that works and we later get a 401 on the real request, we still fail anyway. In the case of proxy_request(), we don't know ahead of time whether the request is large or not; we just proxy the data through. And we don't do the probe thing at all. So wouldn't we dropping some data for the follow-up request? -Peff
