On Mon, Feb 04, 2019 at 10:49:05AM +0100, Johannes Schindelin wrote: > Hi Gábor, > > On Sat, 2 Feb 2019, SZEDER Gábor wrote: > > > Before installing the necessary dependencies, our OSX build jobs run > > 'brew update --quiet'. This is problematic for two reasons: > > > > - This '--quiet' flag apparently broke overnight, resulting in > > errored builds: > > > > +brew update --quiet > > ==> Downloading https://homebrew.bintray.com/bottles-portable-ruby/portable-ruby-2.3.7.mavericks.bottle.tar.gz > > ######################################################################## 100.0% > > ==> Pouring portable-ruby-2.3.7.mavericks.bottle.tar.gz > > Usage: brew update_report [--preinstall] > > The Ruby implementation of brew update. Never called manually. > > --preinstall Run in 'auto-update' mode (faster, less > > output). > > -f, --force Override warnings and enable potentially > > unsafe operations. > > -d, --debug Display any debugging information. > > -v, --verbose Make some output more verbose. > > -h, --help Show this message. > > Error: invalid option: --quiet > > The command "ci/install-dependencies.sh" failed and exited with 1 during . > > > > I belive that this breakage will be noticed and fixed soon-ish, so > > we could probably just wait a bit for this issue to solve itself, > > but: > > > > - 'brew update --quiet' wasn't really quiet in the first place, as > > it listed over about 2000 lines worth of available packages that > > we absolutely don't care about, see e.g. one of the latest > > 'master' builds: > > > > https://travis-ci.org/git/git/jobs/486134962#L113 > > > > So drop this '--quiet' option and redirect 'brew update's standard > > output to /dev/null to make it really quiet, thereby making the OSX > > builds work again despite the above mentioned breakage. > > > > Signed-off-by: SZEDER Gábor <szeder.dev@xxxxxxxxx> > > --- > > > > Notes: > > There is no conflict with Dscho's Azure Pipelines patch series; the > > patch contexts overlap a bit, but the auto-merging results look good > > to me. > > And this indeed also affects Azure Pipelines. > > Since Junio's workflow is very different from GitHub Flow (where this > issue would be worked around with a simple, single Pull Request), I doubt that a single PR could be sufficient, because it won't help contributors who want to run CI builds in their own forks; they would have to rebase their branches on top of the fix, or cherry-pick it, or whatnot. > we have > no prayer at a workaround on our side, though: pretty much *all* of the > next builds of Junio's branches will be broken, unless he chooses to > backport your patch to all of the base commits he chose for those > branches. > > So our best bet at not getting overwhelmed with failed builds ... Oh, in my long-time for-fun semi-automated CI experiment [1] all integration branches and cooking topics are still just fine :) they all have been including this patch (among many others) for quite some time now (since when the list of available Homebrew packages was "only" about 1700 lines... about a year ago). Unfortunately, I never upstreamed it, because that long list of packages is folded up anyway when viewing the logs, so why bother... In hindsight, I should have. Oh, well. [1] https://travis-ci.org/szeder/git-cooking-topics-for-travis-ci/branches > is to help > Homebrew get `brew update --quiet` to work again. I just opened a ticket > to that end: > > https://github.com/Homebrew/brew/issues/5666 > > I do like your patch, though, and am very much in favor of fast-tracking > it all the way down to `maint`. > > Ciao, > Dscho > > > ci/install-dependencies.sh | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/ci/install-dependencies.sh b/ci/install-dependencies.sh > > index 06c3546e1e..5968efdbbe 100755 > > --- a/ci/install-dependencies.sh > > +++ b/ci/install-dependencies.sh > > @@ -34,7 +34,7 @@ linux-clang|linux-gcc) > > popd > > ;; > > osx-clang|osx-gcc) > > - brew update --quiet > > + brew update >/dev/null > > # Uncomment this if you want to run perf tests: > > # brew install gnu-time > > brew install git-lfs gettext > > -- > > 2.20.1.642.gc55a771460
