чт, 31 янв. 2019 г. в 21:47, Anders Waldenborg <anders@xxxxxxx>: > > > Оля Тележная writes: > >> Oh my. I wasn't aware that there was a totally separate string > >> interpolation implementation used for ref filters. That one has > >> separated parsing, making it more amenable to good error handling. > >> I wonder if that could be generalized and reused for pretty formats. > >> > >> However I doubt I will have time to dig deeper into that in near time. > >> > > > > Sorry, I haven't read your patch in details. If you will be at Git Merge > > tomorrow, you could ask me any questions, I can explain how for-each-ref > > formatting works amd maybe even give you some ideas how to use its logic in > > pretty, I was thinking about it a bit. > > No, unfortunately I'm not at Git Merge. > > I think I got how the formatting work. But if you have ideas on how to > reuse the logic I'm all ears. Maybe my advices will be not suitable: I know how ref-filter works, but I know only a few about pretty system. The main point is that we need to save backward compatibility, and that means that we can't just drop pretty logic and start using ref-filter one there. I guess it's not so hard to make like translation table between pretty commands and ref-filter one. For example, 'short' in pretty means 'commit %(objectname)%0aAuthor: %(author)' in ref-filter. So if I wanted to change pretty logic, I would add support of all ref-filter commands and make translation table for backward compatibility. Hope it was helpful. >
