On Fri, Feb 1, 2019 at 11:22 AM Jiang Xin <worldhello.net@xxxxxxxxx> wrote:
> Add test cases for git pack-redundant to validate new algorithm for git
> pack-redundant.
>
> Signed-off-by: Jiang Xin <zhiyou.jx@xxxxxxxxxxxxxxx>
> ---
> diff --git a/t/t5323-pack-redundant.sh b/t/t5323-pack-redundant.sh
> @@ -0,0 +1,510 @@
> +# Note: DO NOT run it in a subshell, otherwise the variables will not be set
Which variables won't be set? It's not clear what this restriction is about.
> +# Usage: create_commits_in <repo> A B C ...
> +create_commits_in () {
> + repo="$1" &&
> + parent=$(git -C "$repo" rev-parse HEAD^{} 2>/dev/null) || parent=
Broken &&-chain. Instead, perhaps:
if ! parent=$(git -C "$repo" rev-parse HEAD^{} 2>/dev/null)
then
parent=
fi &&
or something simpler.
> + T=$(git -C "$repo" write-tree) &&
> + shift &&
> + while test $# -gt 0
> + do
> + name=$1 &&
> + test_tick &&
> + if test -z "$parent"
> + then
> + oid=$(echo $name | git -C "$repo" commit-tree $T)
> + else
> + oid=$(echo $name | git -C "$repo" commit-tree -p $parent $T)
> + fi &&
> + eval $name=$oid &&
> + parent=$oid &&
> + shift ||
> + return 1
> + done
Broken &&-chain. Use:
done &&
> + git -C "$repo" update-ref refs/heads/master $oid
> +}
> +
> +# Note: DO NOT run it in a subshell, otherwise the variables will not be set
> +create_pack_1 () {
> + P1=$(git -C "$master_repo/objects/pack" pack-objects -q pack <<-EOF
Which variables? Note that you can capture output of a subshell into a
variable, if necessary.
