> On Jan 30, 2019, at 11:15, Johannes Schindelin <Johannes.Schindelin@xxxxxx> wrote: > > Hi Jeremy, > > On Wed, 30 Jan 2019, Jeremy Huddleston Sequoia wrote: > >>> On Jan 30, 2019, at 01:50, brian m. carlson >>> <sandals@xxxxxxxxxxxxxxxxxxxx> wrote: >>> >>> On Tue, Jan 29, 2019 at 11:38:15AM -0800, Jeremy Huddleston Sequoia wrote: >>>> See <rdar://problem/10573201> >>> >>> It's my understanding that Radars aren't public. Could you summarize the >>> reasons behind this change in the commit message for those of us who >>> don't have access to view this issue? >> >> There was a bug in some tool in our packaging pipeline that resulted in >> hardlinks not being preserved. That was fixed, but I decided to leave >> these as symlinks anyways in case users did a file operation on >> Xcode.app that didn't preserve hard links. >> >> The point here is that it would probably be nice to have hard vs soft be >> a configuration option. > > Your patch does not make it a configuration option. (Or a build option, > which would probably be the more appropriate thing to do here.) > > You need not spend the time on this, though, as Ævar already did, in > ad874608d8c9 (Makefile: optionally symlink libexec/git-core binaries to > bin/git, 2018-03-13), which made it in v2.18.0 already. All you need to do > is to define INSTALL_SYMLINKS. Oh great, thanks! I missed that when doing the last rebase.
