On Tue, Jan 29, 2019 at 03:10:30PM -0800, Junio C Hamano wrote: > Jeremy Huddleston Sequoia <jeremyhu@xxxxxxxxx> writes: > > > Useful for setting up osxkeychain in Xcode.app's gitconfig > > > > Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@xxxxxxxxx> > > --- > > A concern shared with 13/13 is this. > > While it may not hurt too much to look at one extra location even on > non-Apple platform, it probably is a mistake to have this xcode > specific change in generic part of the system like config.c or > attr.c. For that matter, would it make sense to force Apple uses to > look at one extra location in the first place? In other words, we > already have "system wide" location (i.e. system_path(ETC_GITCONFIG)) > defined so system owners can give reasonable default to its users. > The value of not using that facility and instead adding yet another > place is dubious. I think it's relevant in this case if I point out what the gitconfig and gitattributes files contain on macOS. The gitconfig file sets up the default credential helper, and the gitattributes file sets up default diff helpers for Objective C and Swift. To my knowledge, I believe what other distributors (including Homebrew) do is they provide the system configuration file with default options if one is missing, allowing the user to retain or delete these options as the administrator sees fit. Apple may or may not want to do that, but I believe that's probably the way that we'll choose to support. While distributors will of course customize Git in whatever way seems most appropriate, I think it's better if those customizations are editable by the user, since that makes it easier to write per-user configuration files that are consistent across platforms. For a tool like Git, that can be quite helpful. -- brian m. carlson: Houston, Texas, US OpenPGP: https://keybase.io/bk2204
Attachment:
signature.asc
Description: PGP signature
