Hi Stolee, On Tue, 29 Jan 2019, Derrick Stolee via GitGitGadget wrote: > From: Derrick Stolee <dstolee@xxxxxxxxxxxxx> > > When running the test suite for code coverage using > 'make coverage-test', a single test failure stops the > test suite from completing. This leads to significant > undercounting of covered blocks. > > Add two new targets to the Makefile: > > * 'prove' runs the test suite using 'prove'. > > * 'coverage-prove' compiles the source using the > coverage flags, then runs the test suite using > 'prove'. > > These targets are modeled after the 'test' and > 'coverage-test' targets. The rationale, and the diff (after reading what `test` and `coverage-test` do), make a lot of sense to me. Thanks, Dscho > > Signed-off-by: Derrick Stolee <dstolee@xxxxxxxxxxxxx> > --- > Makefile | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Makefile b/Makefile > index 1a44c811aa..ec886635ae 100644 > --- a/Makefile > +++ b/Makefile > @@ -2665,6 +2665,9 @@ export TEST_NO_MALLOC_CHECK > test: all > $(MAKE) -C t/ all > > +prove: all > + $(MAKE) -C t/ prove > + > perf: all > $(MAKE) -C t/perf/ all > > @@ -3077,6 +3080,10 @@ coverage-test: coverage-clean-results coverage-compile > $(MAKE) CFLAGS="$(COVERAGE_CFLAGS)" LDFLAGS="$(COVERAGE_LDFLAGS)" \ > DEFAULT_TEST_TARGET=test -j1 test > > +coverage-prove: coverage-clean-results coverage-compile > + $(MAKE) CFLAGS="$(COVERAGE_CFLAGS)" LDFLAGS="$(COVERAGE_LDFLAGS)" \ > + DEFAULT_TEST_TARGET=prove -j1 prove > + > coverage-report: > $(QUIET_GCOV)for dir in $(object_dirs); do \ > $(GCOV) $(GCOVFLAGS) --object-directory=$$dir $$dir*.c || exit; \ > -- > gitgitgadget >
