Re: [PATCH v4 09/21] Add a build definition for Azure DevOps

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Junio,

On Wed, 23 Jan 2019, Junio C Hamano wrote:

> "Johannes Schindelin via GitGitGadget" <gitgitgadget@xxxxxxxxx>
> writes:
> 
> > From: Johannes Schindelin <johannes.schindelin@xxxxxx>
> >
> > This commit adds an azure-pipelines.yml file which is Azure DevOps'
> > equivalent to Travis CI's .travis.yml.
> >
> > To make things a bit easier to understand, we refrain from using the
> > `matrix` feature here because (while it is powerful) it can be a bit
> > confusing to users who are not familiar with CI setups. Therefore, we
> > use a separate phase even for similar configurations (such as GCC vs
> > Clang on Linux, GCC vs Clang on macOS).
> >
> > Also, we make use of the shiny new feature we just introduced where the
> > test suite can output JUnit-style .xml files. This information is made
> > available in a nice UI that allows the viewer to filter by phase and/or
> > test number, and to see trends such as: number of (failing) tests, time
> > spent running the test suite, etc.
> >
> > Signed-off-by: Johannes Schindelin <johannes.schindelin@xxxxxx>
> > ---
> >  azure-pipelines.yml   | 306 ++++++++++++++++++++++++++++++++++++++++++
> 
> Way-overlong line in this file bothers me somewhat, but let's say
> these are not for human consumption and it is OK ;-)

Right ;-)

> > diff --git a/ci/lib.sh b/ci/lib.sh
> > index a9eb4f4eae..91cf1402bf 100755
> > --- a/ci/lib.sh
> > +++ b/ci/lib.sh
> > @@ -42,7 +42,7 @@ then
> >  
> >  	BREW_INSTALL_PACKAGES=
> >  	export GIT_PROVE_OPTS="--timer --jobs 10 --state=failed,slow,save"
> > -	export GIT_TEST_OPTS="--quiet --write-junit-xml"
> > +	export GIT_TEST_OPTS="--verbose-log -x --write-junit-xml"
> >  fi
> 
> Interesting to see this change here, not in the previous step.  If
> we stopped at 08/21, did we even have a chance to enter this elif
> block?  If not, it probably is sane to squash this hunk to the
> previous one that introduced the elif block.

Oh my. You're right. I think I just picked the wrong commit to make this
fixup.

Will squash as suggested,
Dscho



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux