From: Daniel Ferreira <bnmvco@xxxxxxxxx> Call the newly introduced add--helper builtin in status_cmd() instead of relying on add--interactive's Perl functions to print the numstat. If an error occurs, it will be reported, but the Perl script will not exit, since the add--helper is called within an eval block. As the Perl script will go away soon, so will this scenario, where the built-in helper is called from the Perl script. Combined with the fact that it would be hard to test, we'll pass on adding a regression test for this. Signed-off-by: Daniel Ferreira <bnmvco@xxxxxxxxx> Signed-off-by: Slavica Djukic <slawica92@xxxxxxxxxxx> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> --- git-add--interactive.perl | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/git-add--interactive.perl b/git-add--interactive.perl index 20eb81cc92..c2c6b4d5e3 100755 --- a/git-add--interactive.perl +++ b/git-add--interactive.perl @@ -597,9 +597,8 @@ sub prompt_help_cmd { } sub status_cmd { - list_and_choose({ LIST_ONLY => 1, HEADER => $status_head }, - list_modified()); - print "\n"; + my @status_cmd = ("git", "add--helper", "--status"); + !system(@status_cmd) or die "@status_cmd exited with code $?"; } sub say_n_paths { -- gitgitgadget