Re: [PATCH v2 2/3] blame: add the ability to ignore commits and their changes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 17.01.2019 um 21:29 schrieb Barret Rhoden:
> The blame_entry will get passed up the tree until we find a commit that
> has a diff chunk that affects those lines.  If an ignored commit added
> more lines than it removed, the blame will fall on a commit that made a
> change nearby.  There is no general solution here, just a best-effort
> approach.  For a trivial example, consider ignoring this commit:
>
> Z: "Adding Lines"
>  foo
> +No commit
> +ever touched
> +these lines
>  bar

Wouldn't it make more sense to assign such lines to unknown, perhaps
represented by an all-zero commit ID, instead of blaming a semi-random
bystander?

René




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux