Hi Gábor, On Thu, 17 Jan 2019, SZEDER Gábor wrote: > All Travis CI build jobs run the test suite with 'make --quiet test'. > > On one hand, being quiet doesn't save us from much clutter in the > output: > > $ make test |wc -l > 861 > $ make --quiet test |wc -l > 848 > > It only spares 13 lines, mostly the output of entering the 't/' > directory and the pre- and post-cleanup commands, which is negligible > compared to the ~700 lines printed while building Git and the ~850 > lines of 'prove' output. > > On the other hand, it's asking for trouble. In our CI build scripts > we build Git and run the test suite in two separate 'make' > invocations. In a prelimiary version of one of the later patches in s/prelimiary/preliminary/ > this series, to explicitly specify which compiler to use, I changed > them to basically run: > > make CC=$CC > make --quiet test > > naively thinking that it should Just Work... but then that 'make > --quiet test' got all clever on me, noticed the changed build flags, > and then proceeded to rebuild everything with the default 'cc'. And > because of that '--quiet' option, it did so, well, quietly, only > saying "* new build flags", and it was by mere luck that I happened to > notice that something is amiss. > > Let's just drop that '--quiet' option when running the test suite in > all build scripts. > > Signed-off-by: SZEDER Gábor <szeder.dev@xxxxxxxxx> Just like the first two patches, this makes tons of sense to me. I thank you and will read on, Dscho > --- > ci/run-build-and-tests.sh | 4 ++-- > ci/run-linux32-build.sh | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/ci/run-build-and-tests.sh b/ci/run-build-and-tests.sh > index cda170d5c2..84431c097e 100755 > --- a/ci/run-build-and-tests.sh > +++ b/ci/run-build-and-tests.sh > @@ -8,7 +8,7 @@ > ln -s "$cache_dir/.prove" t/.prove > > make --jobs=2 > -make --quiet test > +make test > if test "$jobname" = "linux-gcc" > then > export GIT_TEST_SPLIT_INDEX=yes > @@ -17,7 +17,7 @@ then > export GIT_TEST_OE_DELTA_SIZE=5 > export GIT_TEST_COMMIT_GRAPH=1 > export GIT_TEST_MULTI_PACK_INDEX=1 > - make --quiet test > + make test > fi > > check_unignored_build_artifacts > diff --git a/ci/run-linux32-build.sh b/ci/run-linux32-build.sh > index 2c60d2e70a..26c168a016 100755 > --- a/ci/run-linux32-build.sh > +++ b/ci/run-linux32-build.sh > @@ -56,5 +56,5 @@ linux32 --32bit i386 su -m -l $CI_USER -c ' > cd /usr/src/git > test -n "$cache_dir" && ln -s "$cache_dir/.prove" t/.prove > make --jobs=2 > - make --quiet test > + make test > ' > -- > 2.20.1.499.gf60de1223c > >
