> On Tue, Jan 15, 2019 at 11:40:28AM -0800, Jonathan Tan wrote: > > A subsequent patch will teach struct packet_reader a new field that, if > > set, instructs it to interpret read data as multiplexed. This will > > create a dependency from pkt-line to sideband. > > > > To avoid a circular dependency, split recv_sideband() into 2 parts: the > > reading loop (left in recv_sideband()) and the processing of the > > contents (in demultiplex_sideband()), and move the former into pkt-line. > > This reverses the direction of dependency: sideband no longer depends on > > pkt-line, and pkt-line now depends on sideband. > > In the last couple of days I noticed occasional but frequent failures > in the test 'leading space' in 't5409-colorize-remote-messas.sh' on > 'pu' and on this topic. Bisect suggests that this patch is the > culprit, but of course bisecting an occasional test failure can't be > completely trusted. > > The trace output of the failing test looks like this: Thanks for checking. Junio noticed a similar thing and I have replied to it here: https://public-inbox.org/git/20190116003828.64889-1-jonathantanmy@xxxxxxxxxx/ I'll try to ensure that this issue is fixed in the subsequent version.
