Josh Steadmon <steadmon@xxxxxxxxxx> writes:
> Signed-off-by: Josh Steadmon <steadmon@xxxxxxxxxx>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 6b72f37c29..bbcfc2bc9f 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -3104,7 +3104,7 @@ cover_db_html: cover_db
> # An example command to build against libFuzzer from LLVM 4.0.0:
> #
> # make CC=clang CXX=clang++ \
> -# FUZZ_CXXFLAGS="-fsanitize-coverage=trace-pc-guard -fsanitize=address" \
> +# CFLAGS="-fsanitize-coverage=trace-pc-guard -fsanitize=address" \
> # LIB_FUZZING_ENGINE=/usr/lib/llvm-4.0/lib/libFuzzer.a \
> # fuzz-all
> #
I know this appeared in v2 of the series, but I cannot quite read
the reasoning/justification behind this change. After this hunk
there is
FUZZ_CXXFLAGS ?= $(CFLAGS)
so if you do not give CFLAGS but give FUZZ_CXXFLAGS, like the
sample, shouldn't it have worked just fine? IOW "correct" in the
title is a bit too terse as an explanation for this change.
