"Derrick Stolee via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes: > From: Derrick Stolee <dstolee@xxxxxxxxxxxxx> > > When creating a pack-file using 'git pack-objects --revs' we provide > a list of interesting and uninteresting commits. For example, a push > operation would make the local topic branch be interesting and the > known remote refs as uninteresting. We want to discover the set of > new objects to send to the server as a thin pack. > > We walk these commits until we discover a frontier of commits such > that every commit walk starting at interesting commits ends in a root > commit or unintersting commit. We then need to discover which > non-commit objects are reachable from uninteresting commits. This > commit walk is not changing during this series. > > The mark_edges_uninteresting() method in list-objects.c iterates on > the commit list and does the following: > > * If the commit is UNINTERSTING, then mark its root tree and every > object it can reach as UNINTERESTING. > > * If the commit is interesting, then mark the root tree of every > UNINTERSTING parent (and all objects that tree can reach) as > UNINTERSTING. > > At the very end, we repeat the process on every commit directly > given to the revision walk from stdin. This helps ensure we properly > cover shallow commits that otherwise were not included in the > frontier. > > The logic to recursively follow trees is in the > mark_tree_uninteresting() method in revision.c. The algorithm avoids > duplicate work by not recursing into trees that are already marked > UNINTERSTING. > > Add a new 'sparse' option to the mark_edges_uninteresting() method > that performs this logic in a slightly new way. As we iterate over > the commits, we add all of the root trees to an oidset. Then, call > mark_trees_uninteresting_sparse() on that oidset. Note that we > include interesting trees in this process. The current implementation > of mark_trees_unintersting_sparse() will walk the same trees as > the old logic, but this will be replaced in a later change. It is unclear what "a slightly new way" refers to. The updated code adds the UNINTERSTING edge commits and UNINTERSTING parents of interesting edge commits (the latter is done using the new add-edge-parents() helper function) to an oidset and calls the new helper introduced in [1/6] to ensure all the objects reachable from these UNINTERSTING trees become UNINTERSTING. Which seems to be doing exactly the same thing as the original. Puzzled.
