On Fri, Jan 11, 2019 at 3:07 AM Stefan Beller <sbeller@xxxxxxxxxx> wrote: > > > I had a look at https://gitlab.com/pclouds/git/commits/submodules-in-worktrees, > > and it doesn't seem to be quite all okay. > > > > The submodule update step of the repro (that breaks the config on 2.20) emits > > an error message instead, and leaves the config unchanged: > > git -C b2 submodule update > > fatal: could not set 'core.worktree' to '../../../../../../b2/a' > > It looks a bit like it's still trying to do the wrong thing, but errors out > > during the attempt (repo_config_set_worktree_gently returns false). > > There is more than just that. After adding the worktrees, > (and after the first status call) > > $ cat b2/.git > gitdir: /u/git/t/trash directory.t7419-submodule-worktrees/b/.git/worktrees/b2 > $ cat b2/a/.git > gitdir: /u/git/t/trash > directory.t7419-submodule-worktrees/b/.git/modules/a/worktrees/a > > Are worktrees using absolute path for their gitlinks? Yes. Moving to relative paths is on my todo list and I probably should get to it after I'm mostly done (*) with submodule support (*) Sharing submodule repos between worktrees is still something not addressed. -- Duy
