Diff from v2[1]:
* Remove http_resonse_dest
This was introduced to have a filename for freopen. Jeff King proposed [2]
using fflush and ftruncate and this makes this struct not needed.
* Unset CURLOPT_FAILONERROR only when it's necessary.
Previously, CURLOPT_FAILONERROR was unset for everything. This patch series
does so only when it's necessary. This is from the observation in [3] that
pointed out there are other possible code paths that hit http.c.
* Split the patches for easier review
[1]: https://public-inbox.org/git/20181229194447.157763-1-masayasuzuki@xxxxxxxxxx/
[2]: https://public-inbox.org/git/20190104101149.GA26185@xxxxxxxxxxxxxxxxxxxxx/
[3]: https://public-inbox.org/git/20190104104907.GC26185@xxxxxxxxxxxxxxxxxxxxx/
Masaya Suzuki (5):
http: support file handles for HTTP_KEEP_ERROR
http: enable keep_error for HTTP requests
remote-curl: define struct for CURLOPT_WRITEFUNCTION
remote-curl: unset CURLOPT_FAILONERROR
test: test GIT_CURL_VERBOSE=1 shows an error
http.c | 27 +++++++++++++--------------
http.h | 1 -
remote-curl.c | 29 ++++++++++++++++++++++++-----
t/lib-httpd/apache.conf | 1 +
t/t5581-http-curl-verbose.sh | 28 ++++++++++++++++++++++++++++
5 files changed, 66 insertions(+), 20 deletions(-)
create mode 100755 t/t5581-http-curl-verbose.sh
--
2.20.1.97.g81188d93c3-goog
