On Wed, Jan 02, 2019 at 10:56:45AM -0800, Junio C Hamano wrote: > This is good as a goal, but the implementation seems to be overly > eager to dereference any symlink or non-regular file found in any > level of recursion. The use case presented as the justification in > the proposed log message, and the explanation in the documentation, > suggests that only the paths given from the command line are treated > this way. > > It may make sense to do this as two orthgonal flags. Dereference > symlinks and named pipes given from the command line is one use > case. Dereference any symlinks encountered during recursion is > another. And the latter might be useful even inside a repository > as an option, even though the former would never make sense unless > running in --no-index mode. Yeah, I definitely think I'll be doing a reroll to address the recursion issue as Peff suggested. I've just been on vacation and will be traveling again soon, so I haven't gotten to it yet. Feel free to wait for the reroll before picking it up. -- brian m. carlson: Houston, Texas, US OpenPGP: https://keybase.io/bk2204
Attachment:
signature.asc
Description: PGP signature
