Stephen & Linda Smith <ischis2@xxxxxxx> writes: > On Wednesday, January 2, 2019 11:15:02 AM MST Junio C Hamano wrote: >> 'date +%s' is used everywhere in this patch but has never been used >> in our test suite before. It is not portable. > So I don't make this mistake again, Is there a reference somewhere for that is > and is not portable? I usually go to http://pubs.opengroup.org/onlinepubs/9699919799/ Even though we do not say "We'll use anything that is in POSIX.1; it is your problem if your platform does not support it", we tend to say "It's not even in POSIX, so let's see if we can avoid it". >> Using "show" here is much better than "log -1" above; using "show >> -s" would be even better. > > I was attempting to test both git log and git show. For get log the `-1` was > to only get the latest commit. > > Are you suggesting that t4202-log.sh not be updated and that only and t7007- > show.sh and t0006-date.sh updated? I am saying that using "log -1" and "show" in different tests _only_ for the value of "Date:" field does not buy us much. And by unifying, I was hoping that the single helper can be placed in a common file that is dot-sourced by these three scripts more easily. Thanks.
