slightly offtopic and definitely not meant to be relevant as a critic on this specific change which I found otherwise fine, but just a heads up that this test itself is bash specific (since it uses arrays, against the recommendation in Documentation/CodingGuidelines) and therefore breaks, at least in NetBSD as reported in : https://public-inbox.org/git/20181121224929.GD5348@jessie.local/ Carlo