Jeff King <peff@xxxxxxxx> writes: > On Tue, Dec 18, 2018 at 01:05:51PM -0800, Josh Steadmon wrote: > >> On 2018.12.18 12:35, Jeff King wrote: >> > On Thu, Dec 13, 2018 at 11:43:55AM -0800, Josh Steadmon wrote: >> > >> > > Add a new fuzz test for the commit graph and fix a buffer read-overflow >> > > that it discovered. Additionally, fix the Makefile instructions for >> > > building fuzzers. >> > > >> > > Changes since V3: >> > > * Improve portability of the new test functionality. >> > >> > I thought there was some question about /dev/zero, which I think is >> > in this version (I don't actually know whether there are portability >> > issues or not, but somebody did mention it). >> > >> > -Peff >> >> I've only found one reference [1] (from 1999) of OS X Server not having >> a /dev/zero. It appears to be present as of 2010 though [2]. > > Thanks for digging. That seems like enough to assume we should try it > and see if any macOS people complain. Our tests have been relying on /dev/zero since 852a1710 ("am: let command-line options override saved options", 2015-08-04) that appeared in v2.6.0. Anybody who has trouble with /dev/zero now has kept silent for about a dozen major releases, I think, and will be silent with this one, too ;-) > > I do wonder if we'll run into problems on Windows, though. > > -Peff