Hi William, On Mon, Dec 24, 2018 at 7:52 PM William Chargin <wchargin@xxxxxxxxx> wrote: > > Hi Christian: thanks for your reply. > > > Changing the default separator as shown above, should make it easier > > to parse the result. > > But this actually also changes which lines are considered trailers, > right? Yes. > If the commit message ends with > > Signed-off-by: one > Signed-off-by| two > > and the user’s `trailer.separators` is set to `:`, then the correct > result should be only `Signed-off-by: one`. But when adding `|` as a > separator, we also see `Signed-off-by: two` in the result. Yeah, but you can perhaps check that the input doesn't contain '|' before doing the above. If it does contain '|' then you can probably find another char that it doesn't contain and use that char instead of '|'. Another solution would be to develop a trailer.outputseparator config option, which should not be very difficult. Best, Christian.
