On Wed, Dec 19, 2018 at 2:19 PM William Hubbs <williamh@xxxxxxxxxx> wrote: > > The author.email, author.name, committer.email and committer.name > settings are analogous to the GIT_AUTHOR_* and GIT_COMMITTER_* > environment variables, but for the git config system. This allows them > to be set separately for each repository. > Great! I didn't realize this wasn't already supported... However your patch does seem to be missing tests. t/t7517-per-repo-email.sh would appear to be a logical place to add them. > Signed-off-by: William Hubbs <williamh@xxxxxxxxxx> > --- > Documentation/config/user.txt | 20 +++++++++++ > builtin/commit.c | 2 +- > cache.h | 5 ++- > config.c | 6 ++++ > ident.c | 68 ++++++++++++++++++++++++++++++++--- > log-tree.c | 3 +- > sequencer.c | 3 +- > 7 files changed, 97 insertions(+), 10 deletions(-) > > diff --git a/Documentation/config/user.txt b/Documentation/config/user.txt > index b5b2ba1199..6ba7002252 100644 > --- a/Documentation/config/user.txt > +++ b/Documentation/config/user.txt > @@ -1,3 +1,23 @@ > +author.email:: > +Your email address to be recorded on the author line of any newly > +created commits. > +If this is not set, we use user.email. > + > +author.name:: > +Your full name to be recorded on the author line of any newly > +created commits. > +If this is not set, we use user.name. > + > +committer.email:: > +Your email address to be recorded on the committer line of any newly > +created commits. > +If this is not set, we use user.email. > + > +committer.name:: > +Your full name to be recorded on the committer line of any newly > +created commits. > +If this is not set, we use user.name. > + > user.email:: > Your email address to be recorded in any newly created commits. > Can be overridden by the `GIT_AUTHOR_EMAIL`, `GIT_COMMITTER_EMAIL`, and I think it would be wise to mention the new config items under user.email and user.name as well.
