The oneline notwithstanding, 13374987dd (completion: use _gitcompbuiltin for format-patch, 2018-11-03) changed also the way send-email options are completed, by asking the git send-email command itself what options it offers. Necessarily, this must fail when built with NO_PERL because send-email itself is a Perl script. Which means that we need the PERL prerequisite for the send-email test case in t9902. Changes since v1: * replaced the commit message by the cover letter, as it was deemed to be more informative. Johannes Schindelin (1): t9902: 'send-email' test case requires PERL t/t9902-completion.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: 5d826e972970a784bd7a7bdf587512510097b8c7 Published-As: https://github.com/gitgitgadget/git/releases/tags/pr-99%2Fdscho%2Ft9902-no-perl-fix-v2 Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-99/dscho/t9902-no-perl-fix-v2 Pull-Request: https://github.com/gitgitgadget/git/pull/99 Range-diff vs v1: 1: 32e6bf2dd3 ! 1: 8e3ddff2c7 t9902: 'send-email' test case requires PERL @@ -2,14 +2,14 @@ t9902: 'send-email' test case requires PERL - With NO_PERL, the `git send-email` script errors out with code 128, - mentioning that Git was built without Perl support. + The oneline notwithstanding, 13374987dd (completion: use _gitcompbuiltin + for format-patch, 2018-11-03) changed also the way send-email options + are completed, by asking the git send-email command itself what options + it offers. - Therefore, when the completion tries to ask for possible completions via - `git send-email --git-completion-helper`, it won't provide what is - necessary for that test case to pass. - - So let's mark it with the PERL prerequisite. + Necessarily, this must fail when built with NO_PERL because send-email + itself is a Perl script. Which means that we need the PERL prerequisite + for the send-email test case in t9902. Signed-off-by: Johannes Schindelin <johannes.schindelin@xxxxxx> -- gitgitgadget
