On Sun, Dec 09, 2018 at 11:56:21PM +0100, SZEDER Gábor wrote: > This patch series tries to make reproducing rare failures in flaky > tests easier: it adds the '--stress' option to our test library to run > the test script repeatedly in multiple parallel jobs, in the hope that > the increased load creates enough variance in the timing of the test's > commands that such a failure is eventually triggered. > > Notable changes since v1: > > - Made it more Peff-friendly :), namely it will now show the log of > the failed test and will rename its trash directory. > > Furthermore, '--stress' will now imply '--verbose -x --immediate'. :) Thanks. I do sympathize with the notion of keeping orthogonal things orthogonal, but I hope that this will make the tool a little more pleasant to use out of the box. We can always tweak the behavior later, too. It's not like this is something user-facing that we've promised as a scripting interface. > - Improved abort handling based on the discussion of the previous > version. (As a result, the patch is so heavily modified, that > 'range-diff' with default parameters consideres it a different > patch; increasing the creation factor then results in one big ugly > diff of a diff, so I left it as-is.) Yeah, this all looked good to me. > - Added a few new patches, mostly preparatory refactorings, though > the first one might be considered a bugfix. I left a few minor comments, but these all looked good to me. -Peff
