Duy Nguyen <pclouds@xxxxxxxxx> writes: > I'm still a bit scared of this invalidation business in unpack-trees. I too was (and I suspect that I would realize that I still am, if I take another fresh look at the current code) afraid when I did the cache-tree work and decided to invalidate it as a whole upfront. > The thing is, we handle two separate index_state there, src_index and > result and invalidation has to be done on the right one (because index > extensions are on src_index until the very end of unpack-trees; > invalidating on 'result' would be no-op and wrong). > ... > Yeah I think it's because cache-tree and untracked cache are already > properly invalidated. ...