On Mon, Dec 10, 2018 at 6:23 PM Elijah Newren <newren@xxxxxxxxx> wrote: > > I wonder if we should move the 'removal' variable in symlinks to > > 'struct checkout' to reduce another global variable. But I guess > > that's the problem for another day. It's not the focus of this series. > > "move the 'removal' variable in symlinks"? I'm having a really hard > time parsing that phrase and the sentence it's embedded in. Could you > reword for me Duy? Sorry s/in symlinks/&.c/. There's a global variable named 'removal' in symlinks.c which is used by schedule_dir_for_removal() and this function in turn is used by unlink_entry(). -- Duy