Re: Bug: segfault during git-prune

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Mon, 2 Jul 2007, Andy Parkins wrote:
> 
> I've pushed it out as-is as a bug fix patch now; and will happilly make the 
> above change on top.  However, I've not understood what all the parameters 
> are for in the process_XXXX() functions:

Yeah, never mind, your patch is fine. The process_xxx() parameters are 
really only there so that process_tree() can generate the proper path and 
names, and they are passed to process_blob/gitlink() just to make all the 
processing look the same.

But it's nonsensical to do for the case of the index (although you could 
pass a NULL path and the name from the index), and we haven't created the 
object array there, so just ignore my suggestion - your original patch is 
fine.

		Linus
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux