On 11/26/2018 2:59 PM, Stefan Beller wrote:
+static int record_ieot(void)
+{
+ int val;
+
Initialize stack val to zero to ensure proper default.
I don't think that is needed here, as we only use `val` when
we first write to it via git_config_get_bool.
Did you spot this via code review and thought of
defensive programming or is there a tool that
has a false positive here?
Code review and defensive programming. I had to review the code in
git_config_get_bool() to see if it always initialized the val even if it
didn't find the requested config variable (esp since we don't pass in a
default value for this function like we do others).
+ if (!git_config_get_bool("index.recordoffsettable", &val))
+ return val;
+ return 0;
+}
