On Sun, Nov 25, 2018 at 11:19 AM Carlo Arenas <carenas@xxxxxxxxx> wrote: > > Signed-off-by: Carlo Marcelo Arenas Belón <carenas@xxxxxxxxx> > > clang with -Wpedantic also catch this (at least with Apple LLVM > version 10.0.0); recent versions of gcc also include that flag and at > least 8.2.0 shows a warning for it, so it might be worth adding it to > developer mode (maybe under the pedantic DEVOPTS), would this be > something I should be adding?, what are the expectations around > warnings and compilers? make DEVELOPER=1 DEVOPTS=pedantic (with either gcc 7.3.0 or 8.2.0) can already catch this. I have no comment if this pedantic should be part of default DEVELOPER=1. But at least in controlled environments like Travis, we could turn it on to catch more. -- Duy
