Re: [PATCH 5/5] index: offer advice for unknown index extensions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Junio C Hamano <gitster@xxxxxxxxx> writes:

> I do not know if it makes sense to have 3 and 5 separate; I suspect
> a single patch that does "clarify the warning, and allow those who
> have no choice in which version of Git to choose squelch it" would
> suffice.

I actually do not mind two patches for these, but I think the
separation presented in the series is wrong (first to kill the
canary completely, and then add it as if it were a completely
separate advice).  

It would make more sense, at least to me, if 

 - the earlier step is to clarify the warning on two points
   (i.e. this is safe to ignore, but you may want to know that you
   are using a stale Git when we see evidence that a newer one has
   already been used here) and then

 - the later step is to optionally make it possible to squelch it
   for those who do not have control over what version of Git they
   are allowed to run.

But again, a single patch to do all of that is also fine.



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux