On 11/20/2018 4:44 AM, Jeff King wrote:
In cases like this I think it's often a good idea to have a perf test.
Those are expensive anyway, and we'd have the double benefit of
exercising the code and showing off the performance improvement. But the
delta-island code only makes sense on a very specialized repo: one where
you have multiple related but diverging histories. You could simulate
that by picking two branches in a repository, but the effect is going to
be miniscule.
The changes in this series look correct. Too bad it is difficult to test.
Perhaps we should add a performance test for the --delta-islands check
that would trigger the failure (and maybe a clone afterwards). There are
lots of freely available forks of git.git that present interesting fork
structure. Here are three that would suffice to make this interesting:
https://github.com/git/git
https://github.com/git-for-windows/git
https://github.com/microsoft/git
Of course, running it on a specific repo is up to the person running the
perf suite.
Thanks,
-Stolee
