On Wed, Nov 14, 2018 at 11:46:18AM +0100, SZEDER Gábor wrote: > cmd_clone() declares two strbufs 'key' and 'value' on the same line, > suggesting that they are used to contruct a config variable's name and > value. However, this is not the case: 'key' is used to construct the > names of multiple config variables, while 'value' is never used as a > value for any of those config variables, or for any other config > variable for that matter, but only to contruct the default fetch > refspec. > > Let's rename 'value' to 'default_refspec' to make the intent clearer. Yep, this is much nicer. -Peff
