On Thu, Nov 15, 2018 at 04:38:44AM -0500, Jeff King wrote: > Is SOURCE_NONE a complete match for what we want? > > I see problems in both directions: > > - sorting by "objectname" works now, but it's marked with SOURCE_OBJ, > and would be forbidden with your patch. I'm actually not sure if > SOURCE_OBJ is accurate; we shouldn't need to access the object to > show it (and we are probably wasting effort loading the full contents > for tools like for-each-ref). > > However, that's not the full story. For objectname:short, it _does_ call > find_unique_abbrev(). So we expect to have an object directory. Oops, I'm apparently bad at reading. It is in fact SOURCE_OTHER, which makes sense (outside of this whole "--sort outside a repo thing"). But we'd ideally distinguish between "objectname" (which should be OK outside a repo) and "objectname:short" (which currently segfaults). -Peff
