steadmon@xxxxxxxxxx writes:
> When a smart HTTP server sends an error message via pkt-line,
> remote-curl will fail to detect the error (which usually results in
> incorrectly falling back to dumb-HTTP mode).
>
> This patch adds a check in discover_refs() for server-side error
> messages, as well as a test case for this issue.
>
> Signed-off-by: Josh Steadmon <steadmon@xxxxxxxxxx>
> ---
Forgot to mention one procedural comment.
As you can see in the To: line of this reply, your MUA is placing
only the e-mail address without name on your From: line.
Preferrably I'd like to see the same string as your sign-off on the
"From:" line in your messages for a bit of human touch ;-) Can you
tweak your MUA to make that happen?
The second preference is to add an in-body header (i.e. as the first
line of the body of the message) so that the body of the message
starts like this:
From: Josh Steadmon <steadmon@xxxxxxxxxx>
When a smart HTTP server sends an error message via pkt-line,
remote-curl will fail to detect the error (which usually results in
incorrectly falling back to dumb-HTTP mode).
This patch adds a check in discover_refs() for server-side error
messages, as well as a test case for this issue.
Signed-off-by: Josh Steadmon <steadmon@xxxxxxxxxx>
---
remote-curl.c | 4 +++-
t/lib-httpd.sh | 1 +
t/lib-httpd/apache.conf | 4 ++++
Either way would make sure that the resulting patch's author line
will be attributed correctly to the same identity as who is signing
it off first as the author.
Thanks.
