On Mon, Nov 12, 2018 at 07:14:23AM -0500, Jeff King wrote:
> just adding a bunch of color variants. It would be nice if we could just
> do this with a run-time parse_color("bold red") or whatever, but we use
> these as static initializers.
I suggested those colors, but now, I think this needs to be
configurable.
I suggested using green and dim green as the obvious theoretical choice
but after using it for a while I found out that both shades are way too
similar, making it really hard to tell by glancing at the output,
especially when they're not side by side.
If we continue with two dual green approach, current branch needs to be
at least bold. But I'm not sure if it's enough.
I've been trying some other colors, and cyan feels neutral-ish.
I think:
GIT_COLOR_BOLD_GREEN /* CURRENT */
GIT_COLOR_CYAN /* WORKTREE */
makes an ok combination.
But I can see where personal preference starts to play a role here, as
the logical solution isn't good enough. Which makes the case for being
able to configure a bit stronger.
Cheers,
Rafael Ascensão
