Anders Waldenborg <anders@xxxxxxx> writes: > + if (opts->separator && first_printed) > + strbuf_addbuf(out, opts->separator); > if (opts->no_key) > - strbuf_addf(out, "%s\n", val.buf); > + strbuf_addf(out, "%s", val.buf); Avoid addf with "%s" alone as a formatter; instead say strbuf_addstr(out, val.buf); cf. contrib/coccinelle/strbuf.cocci
