On Sat, Nov 3, 2018 at 8:25 PM Eric Sunshine <sunshine@xxxxxxxxxxxxxx> wrote: > On Sat, Nov 3, 2018 at 11:31 AM Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> wrote: > > +test_expect_success 't_e_i() exclude case #8' ' > > + git init case8 && > > + ( > > + cd case8 && > > + echo file >file1 && > > + echo file >file2 && > > + git add . && > > Won't this loose git-add invocation end up adding all the junk files > from earlier tests? One might have expected to see the more restricted > invocation: > git add file1 file2 && > to make it easier to reason about the test and not worry about someone > later inserting tests above this one which might interfere with it. Upon reflection, there shouldn't be any junk files since this test is creating a new repository and "file1" and "file2" are the only files present. Apparently, I wasn't paying close enough attention when I made the earlier observation. Anyhow, the more restricted git-add invocation you used in the re-roll is still preferable since it makes the intention obvious. Thanks.
