On Sun, Oct 28, 2018 at 1:15 PM SZEDER Gábor <szeder.dev@xxxxxxxxx> wrote: > > On Sun, Oct 28, 2018 at 06:41:06AM +0100, Duy Nguyen wrote: > > Something fishy is going on but I don't think I'll spend time hunting > > it down so I post here in case somebody else is interested. It might > > also indicate a problem with poison gettext, not the test case too. > > I haven't actually run the test under GETTEXT_POISON, but I stongly > suspect it's the test, or more accurately the helper function > 'test_i18ngrep'. > > The test in question runs > > test_i18ngrep ! "refusing to lose untracked file at" err > > which fails in normal test runs, because 'grep' does find the > undesired string; that's the known breakage. Under GETTEXT_POISION, > however, 'test_i18ngrep' always succeeds because of this condition: > > if test -n "$GETTEXT_POISON" > then > # pretend success > return 0 > fi > > and then in turn the whole test succeeds. And this is something your poison-with-scrambling code does help ;-) ;-) -- Duy
