On Mon, Oct 29, 2018 at 12:44:58PM +0900, Junio C Hamano wrote: > Jeff King <peff@xxxxxxxx> writes: > > > Hmph. So I was speaking before purely hypothetically, but now that your > > patch is in 'next', it is part of my daily build. And indeed, I hit a > > false positive within 5 minutes of building it. ;) > > Sounds like somebody is having not-so-fun-a-time having "I told you > so" moment. The 'dotgit' thing already feels bit convoluted but I > would say that it is still within the realm of reasonable workflow > elements. To be clear, the "dotgit" thing _is_ weird and convoluted. And I imagine that I push Git more than 99% of our users would. But I also won't be surprised if somebody else has something similarly disgusting in the wild. :) TBH, I'm still not really sold on the idea of doing loop detection at all in this case. But I can live with it if others feel strongly. What makes the current patch so bad is that there's no escape hatch (i.e., even a depth counter with a default of "1" would have given me something I could bump). -Peff
