"brian m. carlson" <sandals@xxxxxxxxxxxxxxxxxxxx> writes: >> > + >> > +#include "git-compat-util.h" >> >> this shouldn't be needed and might be discouraged as per the >> instructions in Documentation/CodingGuidelines > > This may not strictly be needed, but removing it makes the header no > longer self-contained, which blows up my (and others') in-editor > linting. That sounds like bending backwards to please tools, though. Can't these in-editor linting learn the local rules of the codebase they are asked to operate on?