Jeff King <peff@xxxxxxxx> writes: > I.e., could we mostly ignore this problem as not applying to most modern > systems? And if there is such a system, give it a fallback like: > > /* > * For systems that use a single buffer for getenv(), this hacks > * around it by giving it _four_ buffers. That's just punting on > * the problem, but it at least gives enough breathing room for > * the caller to do something sane like use non-trivial functions > * to copy the string. It still does nothing for threading, but > * hopefully such systems don't support pthreads in the first place. ;) > */ Tempting. > I dunno. Maybe I am being overly optimistic. But I strongly suspect we > have such bugs already in our code base, and nobody has run into them Yeah, I tend to agree that I would not be surprised at all if we have many such "bugs" that triggers for nobody on modern platforms.
