On 10/25/2018 5:26 AM, Junio C Hamano wrote:
Junio C Hamano <gitster@xxxxxxxxx> writes:
To be honest, I find the second sentence in your rewrite even more
confusing. It reads as if `reset.quiet` configuration variable
can be used to restore the "show what is yet to be added"
behaviour, due to the parenthetical mention of the default behaviour
without any configuration.
The command reports what is yet to be added to the index
after `reset` by default. It can be made to only report
errors with the `--quiet` option, or setting `reset.quiet`
configuration variable to `true` (the latter can be
overriden with `--no-quiet`).
That may not be much better, though X-<.
In any case, the comments are getting closer to the bikeshedding
territory, that can be easily addressed incrementally. I am getting
the impression that everbody agrees that the change is desirable,
sufficiently documented and properly implemented.
Shall we mark it for "Will merge to 'next'" in the what's cooking
report and leave further refinements to incremental updates as
needed?
While not great, I think it is good enough. I don't think either of the
last couple of rewrite attempts were clearly better than what is in the
latest patch. I'd agree we should merge to 'next' and if someone comes
up with something great, we can update it then.
