On Tue, Oct 23, 2018 at 8:47 PM Ben Peart <peartben@xxxxxxxxx> wrote: > > > > On 10/22/2018 10:45 AM, Duy Nguyen wrote: > > On Mon, Oct 22, 2018 at 3:38 PM Ben Peart <peartben@xxxxxxxxx> wrote: > >> > >> From: Ben Peart <benpeart@xxxxxxxxxxxxx> > >> > >> Add a reset.quiet config setting that sets the default value of the --quiet > >> flag when running the reset command. This enables users to change the > >> default behavior to take advantage of the performance advantages of > >> avoiding the scan for unstaged changes after reset. Defaults to false. > >> > >> Signed-off-by: Ben Peart <benpeart@xxxxxxxxxxxxx> > >> --- > >> Documentation/config.txt | 3 +++ > >> Documentation/git-reset.txt | 4 +++- > >> builtin/reset.c | 1 + > >> 3 files changed, 7 insertions(+), 1 deletion(-) > >> > >> diff --git a/Documentation/config.txt b/Documentation/config.txt > >> index f6f4c21a54..a2d1b8b116 100644 > >> --- a/Documentation/config.txt > >> +++ b/Documentation/config.txt > >> @@ -2728,6 +2728,9 @@ rerere.enabled:: > >> `$GIT_DIR`, e.g. if "rerere" was previously used in the > >> repository. > >> > >> +reset.quiet:: > >> + When set to true, 'git reset' will default to the '--quiet' option. > >> + > > > > With 'nd/config-split' topic moving pretty much all config keys out of > > config.txt, you probably want to do the same for this series: add this > > in a new file called Documentation/reset-config.txt then include the > > file here like the sendemail one below. > > > > Seems a bit overkill to pull a line of documentation into a separate > file and replace it with a line of 'import' logic. Perhaps if/when > there is more documentation to pull out that would make more sense. There are a couple benefits of having all config keys stored in the same way (i.e. in separate files). Searching will be easier, you _know_ reset.stuff will be in reset-config.txt. If you mix both ways, you may need to look in config.txt as well as searching reset-config.txt. This single config key also stands out when you look at the end result of nd/config-split. The config split also opens up an opportunity to include command-specific config in individual command man page if done consistently. -- Duy
