On Tue, Oct 23, 2018 at 3:00 PM Jeff King <peff@xxxxxxxx> wrote: > On Tue, Oct 23, 2018 at 02:50:19PM -0700, Carlo Marcelo Arenas Belón wrote: > > #define implement_static_commit_slab(slabname, elemtype) \ > > - implement_commit_slab(slabname, elemtype, static MAYBE_UNUSED) > > + implement_commit_slab(slabname, elemtype, MAYBE_UNUSED static) > > Is this hunk necessary? it works eitherway but the proposed syntax is IMHO better aligned (when used in a function definition) as it matches better the syntax from C++ attribute: maybe_unused (since C++17) [1] __attribute__(unused) (the GCC extension) is meant to be applied to function declarations, but we are not generating those. Carlo [1] https://en.cppreference.com/w/cpp/language/attributes/maybe_unused
