On Tue, Oct 23, 2018 at 2:04 PM Tommi Vainikainen <tvainika@xxxxxxxxx> wrote: > > I configured my local git to fetch with recurseSubmodules = on-demand, > which I found the most convenient setting. However then I noticed that > I mostly use git pull actually to fetch from remotes, but git pull > does not utilize any recurseSubmoddules setting now, or at least I > could not find such. > > I would expect that if git-config has fetch.recurseSubmodules set, > also git pull should use this setting, or at least similar option such > as pull.recurseSubmodules should be available. I'd prefer sharing > fetch.recurseSubmodules setting here. > > I've attached a minimal patch, which I believe implements this > configuration usage, and a test case to show my expected behavior for > git pull. This makes sense to me and the patch looks good to me. It is unclear to me if this is a regression or an oversight of of a6d7eb2c7a (pull: optionally rebase submodules (remote submodule changes only), 2017-06-23) Thanks, Stefan
