On Tue, Oct 23, 2018 at 12:31 PM Slavica <slavicadj.ip2018@xxxxxxxxx> wrote: > This is part of enhancement request that ask for `git stash` to work even if `user.name` is not configured. > The issue is discussed here: https://public-inbox.org/git/87o9debty4.fsf@xxxxxxxxxxxxxxxxxxx/T/#u. As Christian mentioned already, it's best to try to describe the issue succinctly in the commit message so readers can understand it without chasing a link. For this simple case, it should be sufficient to explain that, due to an implementation detail, git-stash undesirably requires 'user.name' and 'user.email' to be set, but shouldn't. > Signed-off-by: Slavica <slawica92@xxxxxxxxxxx> > --- > diff --git a/t/t3903-stash.sh b/t/t3903-stash.sh > @@ -1156,4 +1156,21 @@ test_expect_success 'stash -- <subdir> works with binary files' ' > +test_expect_failure 'stash with HOME as non-existing directory' ' The purpose of this test is to demonstrate that git-stash has an undesirable requirement that 'user.name' and 'user.email' be set. The test title should reflect that. So, instead of talking about non-existent HOME (which is just an implementation detail of the test), a better test title would be something like "stash works when user.name and user.email are not set". > + test_commit 1 && > + test_config user.useconfigonly true && > + test_config stash.usebuiltin true && > + ( > + HOME=$(pwd)/none && > + export HOME && > + unset GIT_AUTHOR_NAME && Use sane_unset() for all of these rather than bare 'unset'. > + unset GIT_AUTHOR_EMAIL && > + unset GIT_COMMITTER_NAME && > + unset GIT_COMMITTER_EMAIL && > + test_must_fail git config user.email && > + echo changed >1.t && > + git stash Christian already mentioned the odd indentation. > + ) > +'
