I wonder if we have a path or the attribute cue at this point of the operation. Your patch may solve that special case of CRLF mangled files, but diffcore-delta works both on text and binary and I am not sure what damange/side-effect you are causing. And you are not ignoring "\r\n vs \n difference" as the comment claims, but are discarding '\r' unconditionally. When we start doing something like that, I would feel much better if we _know_ we are operating on a text file at least. - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html