Hi carlo,
your mail's "From:" line does not record your full name, but the
Signed-off-by: line does. Let's use the latter?
On Mon, 22 Oct 2018, carlo wrote:
> in f48000fc ("Yank writing-back support from gitfakemmap.", 2005-10-08)
> support for writting back changes was removed but the specific prot
> flag that would be used was not checked for)
>
> Signed-off-by: Carlo Marcelo Arenas Belón <carenas@xxxxxxxxx>
ACK!
Thank you,
Johannes
> ---
> compat/mmap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/compat/mmap.c b/compat/mmap.c
> index 7f662fef7b..14d31010df 100644
> --- a/compat/mmap.c
> +++ b/compat/mmap.c
> @@ -4,7 +4,7 @@ void *git_mmap(void *start, size_t length, int prot, int flags, int fd, off_t of
> {
> size_t n = 0;
>
> - if (start != NULL || !(flags & MAP_PRIVATE))
> + if (start != NULL || flags != MAP_PRIVATE || prot != PROT_READ)
> die("Invalid usage of mmap when built with NO_MMAP");
>
> start = xmalloc(length);
> --
> 2.19.1
>
>
